Check for constructor with parameterName parameter #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaa-n
changed the title
buyaa-n
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3665 +/- ##
========================================
Coverage 94.65% 94.65%
========================================
Files 1075 1075
Lines 245459 245560 +101
Branches 14847 14858 +11
========================================
+ Hits 232336 232439 +103
Misses 11072 11072
+ Partials 2051 2049 -2 |
buyaa-n
commented
May 22, 2020
| { | ||
| public void Test(string first) | ||
| { | ||
| throw new System.Text.DecoderFallbackException (""first""); |
There was a problem hiding this comment.
One of the exceptions derived from ArgumentException but not have a constructor with paramName argument
mavasani
approved these changes
May 27, 2020
|
@buyaa-n Can you also update your documentation PR for CA2208 to mention the new semantics? |
@mavasani sure, i have updated the doc few days ago, the PR still open https://github.com/MicrosoftDocs/visualstudio-docs-pr/pull/6584/files#diff-36af8621090aedd8637f2a0e4f1fa1f7R32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes last comment for dotnet/runtime#33763
Related to PR comment
apply the rule to the all ArgumentException-derived types (including itself) that have a constructor accepting a paramName parameter, including user-defined types.dotnet/runtime#35717 (comment)